Template talk:Message

From GodWiki
Jump to navigation Jump to search

Undoing recent changes

I'm going to have to revert the recent edits that were made by Emptysora until we can figure out why the template's broken. I've also added a real-use example to the docs, so that in future, when we preview an edit, we'll catch an issue like this before saving. -- Djonni (talk) 14:04, 24 November 2019 (UTC)

Wait... as I look back through the revision history, the line breaking behaviour continues back many edits, and I know that it worked perfectly fine inline in those previous revisions.
For some reason, the <span>...</span> is being wrapped in a <p>...</p>. Going to dig into it now, instead of reverting, as it doesn't look like that will actually fix it. Not sure what's happening. -- Djonni (talk) 14:07, 24 November 2019 (UTC)
Fixed.png Fixed I don't know what edit it was the introduced the issue, or maybe I'm imagining it that this template ever worked correctly in-line. But now it works correctly in-line! It was the classic pesky newline before the <noinclude>...</noinclude> problem. Annoyed I didn't spot that immediately. -- Djonni (talk) 14:28, 24 November 2019 (UTC)
How rude, I test my templates before putting them in~!
Heh, I’m just kidding. No hard feelings, really. Please, revert my edits if they cause problems. I saw that issue myself, I just wasn’t sure how to fix it. I forgot that the newline between the final }} and the noinclude tag would be problematic. Nice catch! Kind of annoyed I didn’t spot that either, especially with how much reformatting I did. That issue was giving me problems on my todo list. Seriously, thanks for fixing it.
Smiley.png Thank you!
Emptysora (talk) 17:28, 24 November 2019 (UTC)
Heh... Even with testing, we all forget edge cases and use cases. 😉 But clearly, it wasn't your edits that did it, nor my own before that! Who knows how long it was broken for, I didn't look back far enough to be sure. I guess I was imagining that it worked right at all, and it was obviously just a coincidence that I noticed the issue just after a big overhaul of the template, haha. Correlation ≠ causation! -- Djonni (talk) 18:47, 24 November 2019 (UTC)