Template talk:Guild

From GodWiki
Jump to navigation Jump to search

Automatically linking the infobox title

I don't really get this edit to the template.

  1. We already have the |stats= parameter, so now templates that use it will have two links to their stats page
  2. I'm not crazy about "hiding" off-wiki links (even to other Godville servers) with plainlinks
  3. As the edit summary notes, autolinking off |name= is fragile, and may not always work

If the goal is just to automatically link to the guild's stats page, that can be done (though it's a bit fraught with peril even still, since the stats page only exists once a guild has 2+ members), but I think it should be done with the existing "Guild Page:" row of the infobox, not the infobox title. -- FeRDNYC (talk) 05:43, 4 November 2018 (UTC)

What I would propose is this:
  1. We make the Guild Page: link automatic, rather than dependent on being passed a URL in |stats=
  2. |stats=url becomes an override, allowing links to be specified for cases where autogeneration fails and to maintain continuity for existing transclusions of {{Guild}} that use |stats=
  3. |stats=no disables the otherwise-automatic linking, if desired by the guild page author for whatever reason
What do you think? -- FeRDNYC (talk) 05:50, 4 November 2018 (UTC)
If the goal is just to automatically link to the guild's stats page Yep, that was the main idea. I find myself manually typing URLs for /stats/guild/ when I find interesting old guild pages, and this seemed to me (though not to everyone, I can see) a straightforwardly useful change. (The plainlinks was just aesthetic.)
Your proposal does make good sense, though, particularly as noted with pages that use |name=. I'd already considered sensing the existence of |stats= or |name= and switching that header link off in either case, but I was going to do that in a sandbox so I didn't break everything... -- Djonni (talk) 07:51, 4 November 2018 (UTC)
Tick.png Done Implemented.
In making this change, I noticed that |stats= isn't actually meant to link to the guild's stats page (https://stats.godvillegame.com/guilds/Name), it's a link to the guild page (https://godvillegame.com/stats/guild/Name) that predates the stats pages. That makes the name of the parameter unfortunate, but there's nothing we can really do about that. (Or, nothing we could do about it that's worth the hassle.) And, in fact, the URL paths for the guild page links have the same issue (notice how they contain "stats").
While I was there I changed both the forum and stats link to use {{{name|{{PAGENAME}}}}} as the title of the link, instead of ignoring |name= and always blindly using {{PAGENAME}}. -- FeRDNYC (talk) 09:22, 4 November 2018 (UTC)
Yellowtick.png Partly done Not quite done.
Discovered a corner case via Special:ExpandTemplates, if |stats= is included in the transclusion, but left blank, the link will be bad. I'll find the right {{#if to wrap around it, to fix that... -- FeRDNYC (talk) 09:27, 4 November 2018 (UTC)
Tick.png Done Fixed! -- FeRDNYC (talk) 09:38, 4 November 2018 (UTC)