GodWiki talk:Projects/Issue Tracker

From GodWiki
Jump to navigation Jump to search

This is the talk page for discussing improvements to the GodWiki:Projects/Issue Tracker page.

  • Be polite
  • Assume good faith
  • No personal attacks
  • Do not bite the newcomers
  • Respond in a mature manner
  • Be welcoming
  • Maintain civility at all times

Broken stuff with the updates

Shall we make this into a project? I think we've found a few that needs to be fixed and we need to consolidate data.

From my end:

  • {{Top}} To the bottom does not work on mobile - (Fixed this. id = "footer" does not exist in mobile so I anchored it to the privacy link instead since it's the only bottom-most element that appears on both mobile and desktop and it has an id.)
  • Collapsibles not working on mobile - (The nested collapsible bug I found before has been fixed but collapsibles don't work on mobile now. I may have found a lead. Mobile uses collapsible-heading and collapsible-block class instead of mw-collapsible and mw-collapsible-content, respectively to auto collapse sections if you don't have Expand all sections turned on in the settings. Not sure if this can be applied to desktop or we'll all be forced to use the Minerva Neue skin just to keep things consistent.)

From WardPhoenix's sandbox:

  • Title of sandboxes - (Zoombie's comment: I'm not entirely sure why they are suddenly right aligned. Maybe we can set the title's style in {{Infobox}} to text-align: center;? I actually kinda like them being right aligned though. My own infobox on my page is really broken on mobile but that's really my own problem, not a GW-wide problem, because I made some modifications on that.)
  • Margin of diaries included in main pages - (Zoombie's comment: Not sure if this is about the Main Page diaries or diaries in general. Text seems to be wrapping in a weird way in mobile. Not sure how to fix this. Maybe with text-align: justify; and text-justify:inter-character; or something? If it's about the extra space on the top part of the diary entries in the Main Page, this may be caused by the collapsible not working on mobile anymore.)

I don't really have time to investigate further right now but many these notes and comments can help. -- Zoombie Zoombie's page talk with Zoombie 12:36, 3 April 2021 (UTC)

Shall we make this into a project?

I'd say, yes. Easier to track.
From what i could see, most of the issue of mobile view comes from Minerva Neue theme being forced upon us in place of the Vector's, which is the default on desktop (and was default on mobile). I have no idea if this forcing was intentional or not, but it does come with some problems.
Since it's unlikely that people using desktop would take time to change their skin, means will have to keep things steady for two different format, which is surely, going to come with mistakes and mistakes while trying to fix mistakes. And in the end, it's gonna be a mess.
What would you guys think about call dev on the forced theme, if possible putting vector back to default ? --WardPhoenix (talk) 16:07, 3 April 2021 (UTC)

What would you guys think about call dev on the forced theme, if possible putting vector back to default ?

I'd say go for it. Luculuqueraxa reports on the forums that editing while on mobile skin is limited to per section editing. I've checked and confirmed this and recommended reporting this to the devs. In fact, I can't seem to find the edit button for the Main Page when I'm on mobile. There's also the weird Advanced mode setting on mobile that either doesn't seem to be doing anything or I haven't figured out what it actually does. -- Zoombie (talk) 17:01, 3 April 2021 (UTC)

──────────────────────────────────────────────────────────────────────────────────────────────────── I found an annoying workaround for the lack of an edit button on a bunch of pages. I put https://wiki.godvillegame.com/index.php?title=YOURPAGENAME&action=edit&section=0 IN my browser nav bar and replace the YOURPAGENAME with the relevant page name. It's crude, but it usually works. — Preceding unsigned comment added by His portliness (talkcontribs) 06:49, 4 April 2021 (UTC)

Word of God

"Hello there!

This is a feedback from Godwiki community regarding GodWiki update on mobile view side.

Previously, and currently on desktop, the default Wiki skin is Vector. But now the default skin on mobile view is forced to MinervaNeue.

This sadly cause issues on mobile view as it seems there is few imcompatibilities between the two skins coding-wise, meaning that the users on mobile have issues with some functions of the Godwiki (collapsible classes as example).

It was also noted by some people, that editing on mobile view with MinervaNeue was more tedious that it was with Vector (edit only per section instead of whole page as example).

So here comes the request : Is it possible to set back Vector as the default skin for mobile view ?

Thanks in advance and thanks for your great work!" - WardPhoenix

Thanks for your feedback! Few things worth noting here:

1. We never had an intention to force / limit a certain skin. There is a default option, but it can always be changed in the wiki preferences. When designing wiki templates, it's important to keep in mind that people could be using different skins, so using any skin-specific features will almost certainly lead to problems.

2. It looks like there are some quirks in Minerva skin when it's running in mobile-mode. Section edition is one of them. Mediawiki developers are well-aware of this issue, and have been for years (https://phabricator.wikimedia.org/T196915, https://phabricator.wikimedia.org/T228107) but the issue is still there. We'll see if we could find some way around this problem. In the meantime you could use a different skin for whole page edits. (if you don't see the Appearance -> Skin option when using the Minerva skin, try switching to the desktop version using the link at the bottom of the page, and check the Preferences again).

3. Vector is not the best option on phones, as it requires constant zooming and panning just to read things. It was never used as a default skin on mobile on Godwiki. Early on it was wptouch skin (not a part of the standard wiki bundle; it was added exactly for that reason). Later on mediawiki got this new Minerva skin, as Wikipedia was becoming more mobile-friendly. It looked better than wptouch on phones, so it became new mobile default in Godwiki (that happened couple years ago, after the last big wiki update). With an option to use any other skin, of course.

Hope that addresses your questions and concerns. These major wiki updates are never easy and things may go wrong. If you (or anyone else) happen to find anything else that's broken or working incorrectly - please let us know.

Can you ask them to at least set the default the way it was? Most people don't change the default skin simply cuz they have no cLue how, which is to our advantage lol. --His portliness (talk) 16:14, 4 April 2021 (UTC)

It seems that Minerva's Mobile view is quite limited in terms of features (one of them is skin support). Interestingly enough Minerva's Desktop view look pretty much the same on phones, but it has all the standard preferences, including the ones for Appearance. Which is why it's better to just set Minerva's view option to "Desktop" (ndla: when on mobile) and leave it that way. Then you can have both mobile optimized layout on phones and the option to change skins.

Putting this alternative Skin that's bundled with the latest MediaWiki version: Timeless. It feels like a good balance it has a good balance of desktop functionality with responsive layout for mobiles which might solve most of the issues we're having with Minerva Neue. If everyone agrees, I can put this as an overall proposed solution on the project page. -- Zoombie Zoombie's page talk with Zoombie 11:03, 6 April 2021 (UTC)

"Looks like most of the issues listed there are limitations of MobileFrontend/Minerva skin of mediawiki (some of them were reported to mediawiki developers years ago). We can't do much about them other than suggest switching to some other skin.

However, some of them are not clear. E.g. notifications issue. Issues with double diffs doesn't seem to happen for us (maybe it needs a certain way for reproduction)

Double footer issue has been fixed. As for the visual editor issue, it might be due to the size/complexity of the page. Or maybe it's because of the server/wiki configuration. If latter is the case we'll try to fix it.

The screenshot we saw for double diffs was not a bug, but rather a peculiarity of the mobile view (which shouldn't be relevant anymore). As for the notifications issue, we're not sure what this issue is, so it's worth to describe how to reproduce it step by step. As for the skin defaults, they weren't changed with the last update. MinervaNue was a default for mobile for at least two years.

As for the collapsible tables, it may be caused by the particular markup that for chosen for this purpose. Standard wikitext markup shouldn't have this issue.

While we try to check the issues page from time to time, it will still be helpful to send those that can't be solved by community via Ideabox.

As for the Timeless skin, we'll definitely check it. Thanks for the tip.

--His portliness (talk) 11:36, 12 April 2021 (UTC)

It turned out that wiki editors in Russian Godville use collapsibles as well and whatever they use seems to work fine with mobile/Minerva skin. The syntax looks like collapsible table example here: https://www.mediawiki.org/wiki/Manual:Collapsible_elements#Collapsible_tables. We can bring the support for these collapsibles to this wiki, but that may require updating the existing pages to use slightly different syntax. Would that be helpful? Could the wiki community update the old pages to use new syntax? Or if you have any other ideas how this can be fixed (for all skins) please let us know.

The devs have spoken. How much work are we looking at? --His portliness (talk) 05:46, 20 April 2021 (UTC)

I checked the link. We're using the first method (JQuery) for collapsible: https://www.mediawiki.org/wiki/Manual:Collapsible_elements#jQuery.makeCollapsible. Which as noted on the link, does not work on mobile, or rather, with the Minerva Neue skin. It is the universal method for collapsible and can be added to any element. It already ships with the engine core. I've actually seen the source code of this when I inspect pages with ?debug=true added in the url. It doesn't work on Minerva Neue but works with Vector and Timeless (both desktop and mobile) because Minerva Neue is an outlier when it comes to the syntax it uses. It's actually an open issue to get the syntax of that skin in-line with the standard syntax used by other skins.
I tried the third method (Collapsible tables) and it doesn't work here so it looks like we don't have support for that. But, if I'm reading the code correctly, it only works on tables so it won't work on other elements like sections/headers, divs, or lists that we want to be collapsible. That's the limitation of this method. So, adding support for this method will at least enable tables to be collapsible on mobile but other than that it won't help with non-table elements. It also means we'll have to hunt don't every page that has a collapsible table and add collapsible to the table's class. Which isn't really a difficult task since the important collapsible tables are all in the Category:Gameplay and there's really not a lot of them.
The second method on the link, NavFrame, is deprecated in favor of the JQuery method.
Fun facts about the Main pages of different wikis:
  • Russian GV wiki uses tables to layout their Main page. It's the oldest technique for layouting web pages. That's why it looks sorta mobile friendly (even when it isn't really) and looks old-school but it does stay consistent on different devices and it plays well with the wiki engine.
  • We opted for a more modern look and used a more modern technique like flexbox and divs to make it responsive hence our Main page's layout looks different on mobile and desktop but this is causing us problems because we have to work around with whatever default CSS the wiki has.
  • Wikipedia uses both divs and tables in addition to having a separate CSS for the Main page only to make it responsive. That's why if you view Wikipedia, you'd have the feeling that they used the same technique as us but if you check the source code, you'd see that in fact, they're using a different one. They have the advantage of giving the Main page it's own CSS.
So, yeah. These are my observations for now. Tell me if I missed anything or need to clarify anything. -- Zoombie Zoombie's page talk with Zoombie 09:47, 20 April 2021 (UTC)

"Random images on the Main Page don't load"

Errrrr... I don't "see" what kind of issue you guys have. Images displays properly to me on my phone. Aren't you sure it wasn't just a blank picture like this one File:Air guitar.jpg? --WardPhoenix (talk) 08:11, 6 April 2021 (UTC)

Fml. lol. Yeah. 🤣 That's actually it. I forgot to check which file it is and that the Air Guitar file is actually just a white background. But why am I seeing a different image on mobile view? [1] Was the picture shown on mobile view always different from the desktop view? I've never really paid much attention to Random images before. -- Zoombie Zoombie's page talk with Zoombie 10:03, 6 April 2021 (UTC)
Theorically, the image is changed every time the Godwiki cache. Though it's weird that the picture change between desktop and mobile, it could be a cache issue, but that's not really a major issue. We need to keep a watch on that random image for a few day to see if it works as intended though. --WardPhoenix (talk) 10:22, 6 April 2021 (UTC)
Oh that is awkward. It was the File:Air guitar.jpg picture. I should've realized lol. --His portliness (talk) 14:50, 6 April 2021 (UTC)

Moving pages

Am I the only one who can't move pages anymore? -- Zoombie Zoombie's page talk with Zoombie 15:33, 9 April 2021 (UTC)

It does seems like the function have just disappeared indeed... --WardPhoenix (talk) 13:51, 12 April 2021 (UTC)