Template talk:Ideabox votes

From GodWiki
Jump to: navigation, search

This is the talk page for discussing improvements to the Template:Ideabox votes page.

  • Be polite
  • Assume good faith
  • No personal attacks
  • Do not bite the newcomers
  • Respond in a mature manner
  • Be welcoming
  • Maintain civility at all times

Hola!

I've made some edits to {{Ideabox votes}} which, I think, should solve all the problems with the layouts and make it fully usable inside tables. I tried to make a series of small, atomic edits so you could see (if you wished) how each part of the problem was solved, but there wasn't a sensible way to break the last edit into smaller pieces so it's a bit large I'm afraid. (However, that edit concerns itself entirely with the closure of each span, so it is at least a localised edit in that sense.

Please give it a good test in each use case you'd like to use it in (you should have no problems with || cell separation in tables now, I think) and let me know if there remain any required fixes ๐Ÿ˜Š Once we're confident it's working as intended, I'll do a handful of minor enhancements, and perhaps work on a |format=desktop. -- Djonni (talk) 09:39, 25 October 2020 (UTC)

Seems to work as intended, amazing work, it's weird to see how some little change fix things for some reasons ๐Ÿ˜…. Anyway thanks again for the help and good luck trying to add a desktop view version. I quickly added a space before comment on compact view, because I thought it was a little too close from the numbers, don't hesitate to remove it if you don't like! --WardPhoenix (talk) 10:16, 25 October 2020 (UTC)
You were completely right about the comment being too close, it was because I completely missed fixing the ending of the ER span. All corrected now, ER span is terminated correctly in both formats, with corrected spacing. ๐Ÿ˜Š -- Djonni (talk) 14:38, 25 October 2020 (UTC)

ER vote highlighting when no Yes value supplied

Question: In your opinion, if an idea is accepted, and only the ER vote is supplied (i.e., no yes votes have been given), should the ER span be highlighted in blue?

Similarly, if it is rejected but no value supplied for the no votes, should it be highlighted in red?

I can imagine someone who can't be bothered putting in eeeevery single yes-no-dupe-ER vote count using this template to only show the ER votes, and I feel like this is thew ay they would expect the template to behave (even though it's not the way the highlighting behaves in the actual ideabox). -- Djonni (talk) 14:43, 25 October 2020 (UTC)

1) I don't know, I removed the one you made because it's not the usual format of ideabox, and because in mobile view that could make it too much highlight, but if you think that can be useful, then go ahead, this template is free for everyone to edit.
2) Well, imo, I can't see a situation when you would want to display only the ER votes. I mean in that case, you just need to add a style=color:blue and then you have your er display ๐Ÿ˜‚. But if you think that can be useful, then go ahead, this template is free for everyone to edit (wait that sentence feel familiar...) --WardPhoenix (talk) 18:01, 25 October 2020 (UTC)
Mmm, let's leave it for now I guess, as it's true, neither of us are going to use it this way and we have no evidence anyone else will use it ๐Ÿ˜Š -- Djonni (talk) 19:01, 25 October 2020 (UTC)
Well, if you really think the case might happens we could always use a parameter like highlight=full for example which would extend the highlighting to the ER section, with default parameter not highlighting the ER section. --WardPhoenix (talk) 19:44, 25 October 2020 (UTC)

Mobile formatting pedantry

On mobile, the vote summary in Ingenious Pieces has center-aligned text. How about I modify the template so that, by default, it applies a center alignment, which can be adjusted using an |align= parameter? (|align=left or right or center (default))

To do this, I'll change the enclosing <span>...</span> into a <div style="display: inline-block; text-align: {{{align|center}}}; ...">...</div>, which is really a better suit to its layout semantics now that it's multi-line.

While on the subject, do you want the text to be bold in mobile format, as it is now? The ideabox formatting is not bold. -- Djonni (talk) 15:13, 25 October 2020 (UTC)

Align-center could be a good idea for mobile formatting, will probably looks better inside a table also. As for the font-weight, frankly I don't know. On ideabox it's a light one, but imo, on the godwiki it looks better with the bold weight. I leave that one to you if you think lighter is better ^^ --WardPhoenix (talk) 18:01, 25 October 2020 (UTC)
Take a look at the formatting of the mobile vote block now. The text will center itself, and the background colours will make a solid block with no gaps between the lines. As you say, I've also left it bold, as it seems clearer to me. Look good to you? ๐Ÿ˜Š -- Djonni (talk) 19:01, 25 October 2020 (UTC)
It doesn't look good, it looks marvelous! Awesome work again mate! --WardPhoenix (talk) 19:41, 25 October 2020 (UTC)